feat(core): expose MPI-based broadcast #191
Open
+111
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dssgabriel
added
C-enhancement
Member
cedricchevalier19
left a comment
cedricchevalier19
left a comment
There was a problem hiding this comment.
We should add this function in the documentation.
dssgabriel
force-pushed
the
feature/core-broadcast
branch
from
0631780 to
0bbb57c
Compare
cwpearson
added
the
SNL-CI-APPROVAL
Also add associated unit test. Signed-off-by: Gabriel Dos Santos <[email protected]> Signed-off-by: Cedric Chevalier <[email protected]>
cedricchevalier19
force-pushed
the
feature/core-broadcast
branch
from
0bbb57c to
225c7d6
Compare
Signed-off-by: Cedric Chevalier <[email protected]>
cedricchevalier19
force-pushed
the
feature/core-broadcast
branch
from
f55f437 to
bac280b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the MPI-based broadcast in the "core" API.
Also, add the associated unit test, which now works with either the MPI or NCCL communication spaces.
Based on #190, which is itself based on #183, so both PRs need to be merged first.